fix: mode selector settings sync with url correctly #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
requested review from
binh-dam-ibigroup
and removed request for
binh-dam-ibigroup
| @@ -223,6 +225,10 @@ function BatchSettings({ | |||
| ) | |||
| const accentColor = tinycolor(baseColor).darken(10) | |||
|
|
|||
| const _onSettingsUpdate = (params: any) => { | |||
| setQueryParam({ queryParamData: params, ...params }) | |||
There was a problem hiding this comment.
Should setQueryParam be used for callback _toggleModeButton too?
There was a problem hiding this comment.
We could use it for that! I don't know of any sync bugs affecting that, I think because those keys are not in conflict with the ones defined in query-params.js in core-utils. But I think it wouldn't hurt to use it and would probably make things more resilient. I'll try it out.
binh-dam-ibigroup
approved these changes
Apr 24, 2024
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
approved these changes
Apr 25, 2024
| @@ -81,6 +82,7 @@ function BatchSettings({ | |||
| modeSettingValues, | |||
| onPlanTripClick, | |||
| routingQuery, | |||
| setQueryParam, | |||
| setUrlSearch, | |||
There was a problem hiding this comment.
Do we still need setUrlSearch? Is it used somewhere else? Should we use something else instead?
There was a problem hiding this comment.
@daniel-heppner-ibigroup Yeah you can delete setUrlSearch from this file.
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The root of this bug is that we replace the URL search with the
currentQueryevery time a trip plan is sent off for keys that are defined incore-utilsquery-paramsfile. However, in some cases (it seems like when a request isn't successful), thecurrentQuerydoesn't get updated with new values from the mode selector. This sync issue means that the old value fromcurrentQueryreplaces the value in the URL.I found what I think is the simplest way of fixing this, by ensuring that the
currentQueryis directly updated at the same time that URL is updated by the mode selector. However, it looks a bit weird because thesetQueryParamfunction only updates URL search values stored insidequeryParamData, while the higher level gets put in currentQuery directly. A bit funky.PR Checklist: